This repository has been archived by the owner on Apr 6, 2020. It is now read-only.
Make it API compatible with the existing vga crate. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveklabnik
added a commit
to intermezzOS/kernel
that referenced
this pull request
Sep 25, 2016
This technically leads to a functional regression, but that's okay for now. The new vga driver does not have the ability to blink the cursor, that's being tracked over at intermezzOS/vga#3 This also needs intermezzOS/vga#2 to be merged before it will work here.
ashleygwilliams
force-pushed
the
master
branch
from
76c7e50 to
f3c97c3
Compare
steveklabnik
force-pushed
the
api
branch
2 times, most recently
from
08ba96c to
238243d
Compare
ashleygwilliams
suggested changes
Sep 25, 2016
| pub static BUFFER: Mutex<Vga> = Mutex::new( | ||
| Vga { | ||
| location: 0xb8000 as *mut u8, | ||
| buffer: [0; ROWS * COLS * 2], |
There was a problem hiding this comment.
update to use COL_BYTES
| /// kprintln!("Hello, world!"); | ||
| /// ``` | ||
| #[macro_export] | ||
| macro_rules! kprintln { |
There was a problem hiding this comment.
can we put this in a separate util.rs
There was a problem hiding this comment.
util.rsis a bad name, but I'm not sure if you're married to the idea of that name or it's just to not have it in this file- I actually want to kill this entirely, but that requires upstream refactoring first.
so, my vote would be to just leave it in for now.
There was a problem hiding this comment.
name it whatever you want ✨ but i want it out of this file
There was a problem hiding this comment.
OR: spend 5min trying to figure out how to get rid of it, and then if we can at least put it all the way at the end
| /// ``` | ||
| /// kprint!("Hello, world!"); | ||
| /// ``` | ||
| #[macro_export] |
|
🎉 |
Changes: 1. Adding the kprintln!/kprint! macros. 2. Adding a spinlock to hold a global, so that those work. This also then requires `const fn` and so makes things nightly-only. For now!
ashleygwilliams
approved these changes
Sep 25, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This also then requires
const fnand so makes things nightly-only. Fornow!
r? @ashleygwilliams