WIP: Upgrade emberfire

[oskarrough]

Work in progress to upgrade emberfire from version 2 to 3. Using this PR to keep track of progress and what needs to be done.

Blocking

• Fix login. There are errors in console to follow. Time to use ember simple auth instead?
• Fix "init" bug in Emberfire (fix native js call to super FirebaseExtended/emberfire#582) - for now, I hardcode it in node_modules after yarn install to get it working. vim node_modules/emberfire/addons/services/firebase-app.ts replace line 28 with super.init(...arguments)

To test

• verify if the this.firebaseApp.database.ServerValue.TIMESTAMP calls are still working (fe9499f)
• verify connected ref still works e98ce01
• make sure tracks are loaded on a channel (did hasMany relationships change?)
• the {{input-autocomplete}} component is temporarily disabled until the Algolia "process" bug is fixed (219a08d)
• Fix the totalTracks method. Opened issue on emberfire. https://github.com/internet4000/radio4000/blob/master/app/models/channel.js#L97-L99

Authentication

Torii hasn't been updated for years and Emberfire works easier with ember-simple-auth now

• Replace torii with simple-auth
• Create user should work
• Replace our own authenticatedRoute mixin with that of simple auth
• Google login
• Facebook login
• Email login
• Logout
• Test authenticated routes work
• Make sure we use new session service from simple-auth, not torii. has to be injected
• test all the linking stuff on /settings

Not tried yet

• Writing/saving data

Also see

• Emberfire version 3 FirebaseExtended/emberfire#542
• https://github.com/firebase/emberfire/blob/master/docs/migration/2XX-to-3XX.md

[oskarrough]

Couldn't make timestamps work. Hardcoded it as {'.sv': 'timestamp'} for now and opened an issue on emberfire.

[oskarrough]

Solution for counting items in a collection: https://github.com/firebase/functions-samples/tree/master/child-count. Hopefully we can find another way to do this like in v2, without needing an extra cloud function.

Solution for timestamp: FirebaseExtended/emberfire#589 (comment)

[4www]

hej! Kind of lost track of this PR. Not sure where we're at... sry

[oskarrough]

It's not easy… Have to take the time with a fresh database and verify that things are still being saved correctly. But there is a new Emberfire release candidate v4 yesterday to try out.

[oskarrough]

If you have energy, try to create a new user and radio and make that work. At the moment there is a firebase rules/permissions error. The user model isn't created after you sign in?

[oskarrough]

This won't happen as we're migrating to https://github.com/radio4000/components

[4www]

just wanted to leave a last comment here, for the lolz

[oskarrough]

Haha. I couldn't get myself to delete the branch 🥲 Well, thank you Emberfire. We learned from you. Time to move on.