Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling object which has multiple images but no image stack #59

Merged
merged 10 commits into from
May 16, 2024

Conversation

glenrobson
Copy link
Collaborator

@glenrobson glenrobson commented Feb 9, 2024

@glenrobson
Copy link
Collaborator Author

glenrobson commented Feb 9, 2024

For discussion regarding the fix to #46. I got to the point where the manifest was generating but the images were invalid according to Cantaloupe. I've implmeented the following:

https://internetarchive-iiif-issue-52.ux-fnf-misc.archive.org/iiif/3/st-anthony-relics-01/manifest.json

Which adds a canvas for each missing image but up for disucssion wether this is the correct behaviour. Should it just fail?

It follows the structure in the missing image recipe: https://preview.iiif.io/cookbook/0283-missing-image/recipe/0283-missing-image/

@digitaldogsbody
Copy link
Collaborator

Retargeted because I remembered about the issue with branches that have underscores

@glenrobson
Copy link
Collaborator Author

It looks like the manifest in #46 is now working and has 5 images:

https://internetarchive-iiif-issue-52.ux-fnf-misc.archive.org/iiif/3/arkivkopia.se-lms-G70-48.3/manifest.json

but the item now has a number of PDFs and is a complex object:

https://archive.org/details/st-anthony-relics-01/

I think its probably safe to close #46 and merge this as it fixes the original issue.

@glenrobson
Copy link
Collaborator Author

glenrobson commented Apr 18, 2024

Strange issue with manifest in Mirador and issue with thumbnails:

https://projectmirador.org/embed/?iiif-content=https://internetarchive-iiif-issue-52.ux-fnf-misc.archive.org/iiif/3/arkivkopia.se-lms-G70-48.3/manifest.json

Issue with this manifest is that all the canvas ids are the same!

@benwbrum benwbrum merged commit e3ef404 into spring-2024 May 16, 2024
4 of 5 checks passed
@benwbrum benwbrum deleted the issue-52 branch May 16, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants