Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mime/type for h.264 HD based on output from file utility. #96

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

markpbaggett
Copy link
Collaborator

@markpbaggett markpbaggett commented Jan 24, 2025

What Does this Do

This addresses Issue 82 by selecting a valid mime-type for h264 HD files. The mime-type used is based on the output of the file utility:

file --mime-type ~/Downloads/Polar_Plunge_Promo_-_2018.HD.mov

/Users/mark.baggett/Downloads/Polar_Plunge_Promo_-_2018.HD.mov: video/mp4

Here is the results of the change in a variety of viewers:

@glenrobson
Copy link
Collaborator

Thanks Mark. A really simple fix in the end but thanks for all of the investigations.

@glenrobson glenrobson linked an issue Jan 24, 2025 that may be closed by this pull request
@glenrobson glenrobson merged commit 704649e into main Jan 24, 2025
4 checks passed
@glenrobson glenrobson deleted the issue-82 branch January 24, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

video item not producing a valid manifest
2 participants