tx-generator: remove mutable state #3815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcFontaine
force-pushed
the
mafo/tx-generator-refactor
branch
from
e7e7600 to
d4ed3d5
Compare
MarcFontaine
force-pushed
the
mafo/tx-generator-refactor
branch
from
d4ed3d5 to
a624206
Compare
MarcFontaine
force-pushed
the
mafo/tx-generator-refactor
branch
from
a624206 to
b6fa049
Compare
MarcFontaine
requested review from
deepfire,
denisshevchenko,
jutaro,
mgmeier and
cleverca22
as code owners
…rUTxO from mutable state
MarcFontaine
force-pushed
the
mafo/tx-generator-refactor
branch
from
b6fa049 to
9ff9675
Compare
MarcFontaine
requested review from
Jimbo4350,
newhoggy and
fmaste
as code owners
mgmeier
approved these changes
Jul 11, 2022
deepfire
approved these changes
Jul 11, 2022
|
bors r+ |
|
Build succeeded: |
iohk-bors bot
added a commit
that referenced
this pull request
Jul 29, 2022
4239: tx-generator: fix a bug r=MarcFontaine a=MarcFontaine The bug was introduced in : #3815. The number of total output transactions of the tx-generator was used for the number of outputs of a single transaction. It was not found because the tests were only run for Plutus workloads and the bug was in a non-Plutus code-branch. Co-authored-by: MarcFontaine <[email protected]>
iohk-bors bot
added a commit
that referenced
this pull request
Jul 29, 2022
4239: tx-generator: fix a bug r=MarcFontaine a=MarcFontaine The bug was introduced in : #3815. The number of total output transactions of the tx-generator was used for the number of outputs of a single transaction. It was not found because the tests were only run for Plutus workloads and the bug was in a non-Plutus code-branch. Co-authored-by: MarcFontaine <[email protected]>
iohk-bors bot
added a commit
that referenced
this pull request
Jul 29, 2022
4239: tx-generator: fix a bug r=MarcFontaine a=MarcFontaine The bug was introduced in : #3815. The number of total output transactions of the tx-generator was used for the number of outputs of a single transaction. It was not found because the tests were only run for Plutus workloads and the bug was in a non-Plutus code-branch. Co-authored-by: MarcFontaine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some data that was passed around as mutable state in tx-generator.
Instead: provide the data a explicit argument.