Rename TestEnableDevelopmentHardForkEras and TestEnableDevelopmentNetworkProtocols #4341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LudvikGalois
requested review from
dcoutts,
Jimbo4350,
erikd,
newhoggy and
JaredCorduan
as code owners
|
It won't be enough to just change the code. There are some tests that use the |
LudvikGalois
force-pushed
the
ludvikgalois/testenableadvertiseprotver
branch
from
ce9fcf3 to
9146c99
Compare
Fixed |
LudvikGalois
force-pushed
the
ludvikgalois/testenableadvertiseprotver
branch
from
9146c99 to
de2ec58
Compare
LudvikGalois
requested review from
deepfire,
mgmeier and
fmaste
as code owners
13 tasks
LudvikGalois
force-pushed
the
ludvikgalois/testenableadvertiseprotver
branch
from
de2ec58 to
c4b4fc8
Compare
LudvikGalois
requested review from
a team and
CarlosLopezDeLara
as code owners
LudvikGalois
force-pushed
the
ludvikgalois/testenableadvertiseprotver
branch
2 times, most recently
from
d0ea45e to
d47eef1
Compare
|
In the diff, I see renames to Can I confirm the code changes are correct and the change log and PR description need to be updated to match the code? |
newhoggy
force-pushed
the
ludvikgalois/testenableadvertiseprotver
branch
from
d47eef1 to
fd284b8
Compare
newhoggy
force-pushed
the
ludvikgalois/testenableadvertiseprotver
branch
from
fd284b8 to
1e3563c
Compare
newhoggy
force-pushed
the
ludvikgalois/testenableadvertiseprotver
branch
5 times, most recently
from
f34f566 to
71c5e9d
Compare
newhoggy
force-pushed
the
ludvikgalois/testenableadvertiseprotver
branch
from
71c5e9d to
234b072
Compare
disassembler
approved these changes
Apr 10, 2023
newhoggy
force-pushed
the
ludvikgalois/testenableadvertiseprotver
branch
from
234b072 to
8ab8d91
Compare
newhoggy
changed the title
TestEnableDevelopmentHardForkEras has been renamed to TestEnableDevelopmentProtVer. An error is thrown if TestEnableDevelopmentHardForkEras is used to avoid it silently being set to False. Closes #4043
newhoggy
force-pushed
the
ludvikgalois/testenableadvertiseprotver
branch
4 times, most recently
from
1f04646 to
eb8ac21
Compare
TestEnableDevelopmentNetworkProtocols has been renamed to ExperimentalProtocols. An error is thrown if TestEnableDevelopmentNetworkProtocols is used to avoid it silently being set to False.
newhoggy
force-pushed
the
ludvikgalois/testenableadvertiseprotver
branch
from
eb8ac21 to
d2cd5c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestEnableDevelopmentHardForkErashas been renamed toExperimentalHardForksEnabled. An error is thrown ifTestEnableDevelopmentHardForkErasis used to avoid it silently being setto
False.TestEnableDevelopmentNetworkProtocolshas been renamed toExperimentalProtocolsEnabled. An error is thrown ifTestEnableDevelopmentNetworkProtocolsis used to avoid it silently being setto
False.Closes #4043
Closes #4470