[monitoring] Disable atproxy #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickmis
approved these changes
Jul 12, 2023
BenjaminPelletier
approved these changes
Jul 12, 2023
There was a problem hiding this comment.
I'm skeptical that atproxy is the cause of the timeout issue (rather than a cause) -- I initially assumed that was the case actually, but then I observed many timeouts from other services.
That being said, atproxy is not currently a critical tool and I agree with this troubleshooting step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #119 comments, the issue reported in #28 seems to be due to the atproxy. I would like to suggest to disable it for few days in the CI to see if the 999 timeout still occurs. If not, that would demonstrate that we isolated the cause of the problem. The atproxy client is replaced by an actual mock_uss when applicable. Please let me know if you would like to approach this differently.