[monitorlib] Improve RID fetch library #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, monitorlib.fetch.rid is hardcoded to use F3411-19. This PR adjusts those fetch objects to be version-independent, supporting both F3411-19 and F3411-22a.
This PR also currently has a quick fix for the MappingProxyType issue addressed in the second commit of #38; the assumption is that #38 will be merged first and I will update this PR to remove that quick fix in favor of the better fix in #38.
I will also update this PR to incorporate the rid_common -> rid change in #37 if #37 is merged first.