Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[security] Update Flask version #913

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BenjaminPelletier
Copy link
Member

This PR updates the version of Flask we use to address a Dependabot finding. This PR also updates a few related packages and runs the pip-compile --generate-hashes --output-file=requirements.txt requirements.in command after first deleting requirements.txt which results in newer versions of certain packages.

@BenjaminPelletier BenjaminPelletier marked this pull request as ready for review January 29, 2025 21:46
Copy link
Contributor

@mickmis mickmis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be some unrelated updates in requirements.txt, and I also see that the file has been generated with Python 3.11 while previously it was 3.12.
The Dockerfile (which I believe is the reference for the Python version to use?) we use uses 3.12.
As such, should the requirements.txt rather be re-generated with Python 3.12?

@BenjaminPelletier
Copy link
Member Author

I'm putting this PR in draft pending #917 + another PR to update the more minor dependencies. Both of those will cause this PR to change substantially when it is brought out of draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants