Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[uss_qualifier/netrid] Add test for NET0730 #914

Merged
merged 4 commits into from
Feb 3, 2025

Conversation

BenjaminPelletier
Copy link
Member

Although we currently have checks for NET0730, I do not believe we have a test that is likely to verify compliance to NET0730 under nominal circumstances. This PR addresses that issue by adding documentation for a test intended to verify NET0730 compliance under many (but not all) circumstances.

NET0730 essentially requires that a Display Provider accept and properly acknowledge incoming notifications due to a subscription the Display Provider has established in the DSS. There is currently no way to ensure a Display Provider necessarily has a subscription in the DSS, but many Display Providers will create a subscription when an observer starts looking at a particular area. Therefore, the DP Behavior test is adjusted in this PR to first query observers before establishing an ISA in an attempt to elicit this subscription-creation behavior, and then check for successful notifications to Display Providers in order to verify compliance to NET0730. The key new check is "DP accepted ISA notification".

An implementation challenge will be determining which participant to credit with NET0730 compliance due to correct notification behavior, since the only identifying information for a notification (SubscriberToNotify) is the subscription_id and url to which the notification is to be sent. The implementation plan is to determine the participant ID from the url by creating and optionally using a new resource type that provides ASTM F3411 identifying information per participant. For this test, this will include an array of regexes identifying URLs that belong to each participant, so the url of the SubscriberToNotify can be used to determine the participant ID of the responsible participant. For other tests, USS ID (sub in access tokens) could also be added to this resource to potentially address other issues we currently have regarding attribution of behaviors observed using F3411 USS IDs.

The next PR will add the new resource described above and optionally provide it to this test scenario. The same PR or a second follow-up will implement the new steps and checks to complete this new test for NET0730.

@BenjaminPelletier BenjaminPelletier marked this pull request as ready for review January 30, 2025 20:37
Copy link
Contributor

@Shastick Shastick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation update looks good.

Should we prioritize adding the implementation for the check for the next deadline?

Copy link
Contributor

@mickmis mickmis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mickmis mickmis merged commit 2113cbf into interuss:main Feb 3, 2025
20 checks passed
@BenjaminPelletier BenjaminPelletier deleted the net0730 branch February 4, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants