Add Ruby 3.0 to test matrix #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Follow Ruby maintenance schedule. See /www.ruby-lang.org/en/downloads/branches/
|
@djberg96 done, but TBH I'm not sure the author will consider it. Also I could help migrating to github actions... Ping @intridea-shared |
|
@BuonOmo Agreed, github actions would be nice. |
sferik
approved these changes
Mar 11, 2024
|
Thanks for submitting this! I would definitely accept a patch that migrated CI to GitHub Actions. Is this something you’re still interested in working on? |
Yes, this will need a little bit of configuration on your hand in the end though. |
|
I don't think I actually have permission to do this, but someone from Intridea should be able to help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added some support for ruby 3.0 in travis configuration. The quotes are just here in case you choose to move to GitHub actions, I can get rid of it if need be.
More on Travis VS GitHub actions. Support for open source from travis has gone missing (https://news.ycombinator.com/item?id=25155203), I can make a next PR moving from travis to github actions if you want 🙂. Done that for most of my repos now, it is easy and support matrix as well (and support windows if you ever want to add tests for it)
If I am to make that PR, may I remove tests for unsupported ruby versions (1.8 up to 2.4, https://www.ruby-lang.org/en/news/2020/04/05/support-of-ruby-2-4-has-ended/)?
Thanks for the great gem!