-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/#140-collapsable-detail-drawer #147
feature/#140-collapsable-detail-drawer #147
Conversation
…omps to use redux store/action flow
…cer and initial state
… with store provider
…modeled on recent changes to results/results list
…davemasselink/katlas into feature/extend-graph-navigation
…png, refined relationships rendered
…y reucer; clean up a notifier test
…class to a node ID under our control * also leaving a TODO comment for @ssmails
…rger, more obvious, control mechanism; also fix bug intuit#145 by including when necessary in graph URL
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
==========================================
- Coverage 62.29% 62.06% -0.23%
==========================================
Files 37 38 +1
Lines 1785 1790 +5
Branches 138 139 +1
==========================================
- Hits 1112 1111 -1
- Misses 541 545 +4
- Partials 132 134 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/ui
in some deployed envs) in QSL graph generated linkNOTE: part of this work overrides styles in the
react-splitter-layout
project, it would probably be less fragile to instead fork that project and then depend on the forked proj rather than rely on potentially fragile class name overriding in this project; will think a bit more and create new issue if helpful