Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/#140-collapsable-detail-drawer #147

Merged

Conversation

davemasselink
Copy link
Collaborator

@davemasselink davemasselink commented Mar 21, 2019

  • modifying default behavior of collapsable drawer such that it starts closed and provides a more obvious "grab here" control mechanism to signal to the user that the feature is still available
  • also fixing bug Actions in list view leads to 404 #145 by way of including application basename (set to /ui in some deployed envs) in QSL graph generated link

NOTE: part of this work overrides styles in the react-splitter-layout project, it would probably be less fragile to instead fork that project and then depend on the forked proj rather than rely on potentially fragile class name overriding in this project; will think a bit more and create new issue if helpful

davemasselink and others added 30 commits December 22, 2018 16:13
…modeled on recent changes to results/results list
…class to a node ID under our control

* also leaving a TODO comment for @ssmails
…rger, more obvious, control mechanism; also fix bug intuit#145 by including  when necessary in graph URL
@davemasselink davemasselink self-assigned this Mar 21, 2019
@davemasselink davemasselink added bug Something isn't working enhancement New feature or request UI front-end related labels Mar 21, 2019
@codecov
Copy link

codecov bot commented Mar 21, 2019

Codecov Report

Merging #147 into master will decrease coverage by 0.22%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
- Coverage   62.29%   62.06%   -0.23%     
==========================================
  Files          37       38       +1     
  Lines        1785     1790       +5     
  Branches      138      139       +1     
==========================================
- Hits         1112     1111       -1     
- Misses        541      545       +4     
- Partials      132      134       +2
Impacted Files Coverage Δ
app/src/components/app/App.js 100% <ø> (ø) ⬆️
app/src/components/graph/GraphContainer.js 64.1% <ø> (ø) ⬆️
app/src/components/results/Results.js 58.97% <ø> (ø) ⬆️
app/src/components/results/ResultList.js 35.71% <0%> (-0.88%) ⬇️
app/src/components/errorPage/ErrorPage.js 25% <25%> (ø)
service/db/dgclient.go 64.73% <0%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbb5f9f...94f3a1f. Read the comment docs.

Copy link
Collaborator

@formuzi formuzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davemasselink davemasselink merged commit 0c82406 into intuit:master Mar 25, 2019
@davemasselink davemasselink deleted the feature/#140-collapsable-detail-drawer branch March 25, 2019 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request UI front-end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants