Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken stacktrace behaviour #99

Merged
merged 1 commit into from
Aug 9, 2018
Merged

Fixed broken stacktrace behaviour #99

merged 1 commit into from
Aug 9, 2018

Conversation

rofinn
Copy link
Member

@rofinn rofinn commented Aug 9, 2018

Closes #96

@codecov
Copy link

codecov bot commented Aug 9, 2018

Codecov Report

Merging #99 into master will decrease coverage by 1.4%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   98.94%   97.53%   -1.41%     
==========================================
  Files          11       11              
  Lines         284      284              
==========================================
- Hits          281      277       -4     
- Misses          3        7       +4
Impacted Files Coverage Δ
src/loggers.jl 100% <100%> (ø) ⬆️
src/stdlib.jl 12.5% <0%> (-50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 441189d...627b5d0. Read the comment docs.

@iamed2
Copy link
Member

iamed2 commented Aug 9, 2018

Good solution, I agree that handlers can be responsible for their own async

@rofinn rofinn merged commit f491d13 into master Aug 9, 2018
@nicoleepp nicoleepp mentioned this pull request Mar 28, 2019
@nicoleepp nicoleepp deleted the rf/stacktrace-fix branch March 28, 2019 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants