circulation: Made loan request start date to be configurable and validated at the backend #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrcastro2
reviewed
Jan 23, 2024
invenio_app_ils/circulation/loaders/schemas/json/loan_request.py
Outdated
Show resolved
Hide resolved
invenio_app_ils/circulation/loaders/schemas/json/loan_request.py
Outdated
Show resolved
Hide resolved
ntarocco
reviewed
Jan 23, 2024
ntarocco
reviewed
Jan 23, 2024
| @@ -104,4 +105,12 @@ def postload_checks(self, data, **kwargs): | |||
| "request_expire_date": [message], | |||
| } | |||
| ) | |||
| elif end - start < loan_request_offset: | |||
There was a problem hiding this comment.
Was there any unit/functional test on this? Would it be possible to add tests?
In particular, I would test:
- if I put a negative value: it looks like you can do that, we should block it
- if I put
0 - if I put a few days
- what happens if I set the config to
2 daysand I make the request now at 11am: will the start date be in 2 days, at 11am (exactly 48 hours), or the check will only compare days and I need to select the third day?
There was a problem hiding this comment.
I will look into the unit test addition for this.
Regarding the 4th point: It will disable today and tomorrow only. The check only compares on the days.
sakshamarora1
force-pushed
the
configure_loan_request_start_date
branch
from
5c451fa to
33eec11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Description
Closes: CERNDocumentServer/cds-ils#835