Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

override.js: estimate the effort to apply it everywhere #2018

Comments

@jrcastro2
Copy link
Contributor

No description provided.

@jrcastro2 jrcastro2 self-assigned this Jan 18, 2023
@jrcastro2
Copy link
Contributor Author

Places where it is currently being used:

In these places the override file it's placed inside the folder that implements the component with the overriden ones. As pointed out by @kpsherva, this forces the users to follow the same folder structure and to create multiple override.js files to customize it.
For instance, for invenio-app-rdm, in order to customize the fronpage and the deposit, the following structure would be needed.

assets/js/invenio_app_rdm/
└── frontpage
    └──override.js
└── deposit
   └──override.js

An alternative to this is to keep the override at the parent module folder and have as many variables as components that accept overrivable components.

assets/js/invenio_app_rdm/
└──override.js

The override.js can contain both variables, one for the fronpage and another for the deposit.

export const depositOverriddenComponents = {...}
export const fronpageOverriddenComponents = {...}

Any ohter ideas are welcomed on how to improve this!

Places where it is missing and should be added:

jrcastro2 added a commit to jrcastro2/react-invenio-forms that referenced this issue Jan 20, 2023
* Singleton class meant to manage the
  global overriden components
* closes inveniosoftware/invenio-app-rdm#2018
jrcastro2 added a commit to jrcastro2/react-invenio-forms that referenced this issue Jan 20, 2023
* Singleton class meant to manage the
  global overriden components
* closes inveniosoftware/invenio-app-rdm#2018
jrcastro2 added a commit to jrcastro2/invenio-app-rdm that referenced this issue Jan 20, 2023
jrcastro2 added a commit to jrcastro2/invenio-app-rdm that referenced this issue Jan 20, 2023
jrcastro2 added a commit to jrcastro2/cookiecutter-invenio-rdm that referenced this issue Jan 20, 2023
jrcastro2 added a commit to jrcastro2/invenio-app-rdm that referenced this issue Jan 23, 2023
jrcastro2 added a commit to jrcastro2/invenio-app-rdm that referenced this issue Jan 23, 2023
jrcastro2 added a commit to jrcastro2/cookiecutter-invenio-rdm that referenced this issue Jan 23, 2023
jrcastro2 added a commit to jrcastro2/invenio-administration that referenced this issue Jan 23, 2023
jrcastro2 added a commit to jrcastro2/invenio-communities that referenced this issue Jan 23, 2023
jrcastro2 added a commit to jrcastro2/invenio-administration that referenced this issue Jan 23, 2023
jrcastro2 added a commit to jrcastro2/invenio-administration that referenced this issue Jan 24, 2023
jrcastro2 added a commit to jrcastro2/invenio-communities that referenced this issue Jan 24, 2023
jrcastro2 added a commit to jrcastro2/invenio-communities that referenced this issue Jan 24, 2023
jrcastro2 added a commit to jrcastro2/invenio-administration that referenced this issue Jan 25, 2023
jrcastro2 added a commit to jrcastro2/invenio-communities that referenced this issue Jan 25, 2023
jrcastro2 added a commit to jrcastro2/invenio-app-rdm that referenced this issue Jan 25, 2023
jrcastro2 added a commit to jrcastro2/invenio-search-ui that referenced this issue Jan 25, 2023
jrcastro2 added a commit to jrcastro2/invenio-communities that referenced this issue Jan 25, 2023
jrcastro2 added a commit to jrcastro2/invenio-app-rdm that referenced this issue Jan 25, 2023
jrcastro2 added a commit to jrcastro2/invenio-search-ui that referenced this issue Jan 25, 2023
@jrcastro2 jrcastro2 removed their assignment Jan 25, 2023
jrcastro2 added a commit to jrcastro2/invenio-app-rdm that referenced this issue Jan 25, 2023
jrcastro2 added a commit to jrcastro2/cookiecutter-invenio-rdm that referenced this issue Jan 25, 2023
jrcastro2 added a commit to jrcastro2/invenio-communities that referenced this issue Jan 25, 2023
jrcastro2 added a commit to jrcastro2/invenio-communities that referenced this issue Jan 25, 2023
kpsherva pushed a commit to inveniosoftware/invenio-search-ui that referenced this issue Jan 26, 2023
kpsherva pushed a commit to inveniosoftware/invenio-communities that referenced this issue Jan 26, 2023
kpsherva pushed a commit to inveniosoftware/cookiecutter-invenio-rdm that referenced this issue Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment