-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
override.js: estimate the effort to apply it everywhere #2018
override.js: estimate the effort to apply it everywhere #2018
Comments
Places where it is currently being used:
In these places the override file it's placed inside the folder that implements the component with the overriden ones. As pointed out by @kpsherva, this forces the users to follow the same folder structure and to create multiple override.js files to customize it.
An alternative to this is to keep the override at the parent module folder and have as many variables as components that accept overrivable components.
The override.js can contain both variables, one for the fronpage and another for the deposit. export const depositOverriddenComponents = {...}
export const fronpageOverriddenComponents = {...} Any ohter ideas are welcomed on how to improve this! Places where it is missing and should be added:
|
* Singleton class meant to manage the global overriden components * closes inveniosoftware/invenio-app-rdm#2018
* Singleton class meant to manage the global overriden components * closes inveniosoftware/invenio-app-rdm#2018
* namespaces search apps * closes inveniosoftware/invenio-app-rdm#2018
* namespaces search apps * closes inveniosoftware/invenio-app-rdm#2018
* namespaces search apps * closes inveniosoftware/invenio-app-rdm#2018
* namespaces search apps * closes inveniosoftware/invenio-app-rdm#2018
* namespaces search apps * closes inveniosoftware/invenio-app-rdm#2018
* namespaces search apps * closes inveniosoftware/invenio-app-rdm#2018
* namespaces search apps * closes inveniosoftware/invenio-app-rdm#2018
* namespaces search apps * closes inveniosoftware/invenio-app-rdm#2018
No description provided.
The text was updated successfully, but these errors were encountered: