Removing branding breaks the search and the record landing page #2869
Labels
bug
Something isn't working
Comments
slint
added a commit
to slint/invenio-rdm-records
that referenced
this issue
Nov 18, 2024
* Closes inveniosoftware/invenio-app-rdm#2869 * Fixes the allowed values that can be passed to set/unset the default community of a record. * Part of the fix is to also accept an empty string ("") as a valid value when setting the "default" field, which was a currently wrong behavior in some UI logic.
slint
added a commit
to slint/invenio-app-rdm
that referenced
this issue
Nov 18, 2024
* Closes inveniosoftware#2869. * Passes "null" instead of empty string ("") as the "default" field value when removing community branding from a record.
alejandromumo
pushed a commit
to inveniosoftware/invenio-rdm-records
that referenced
this issue
Nov 19, 2024
* Closes inveniosoftware/invenio-app-rdm#2869 * Fixes the allowed values that can be passed to set/unset the default community of a record. * Part of the fix is to also accept an empty string ("") as a valid value when setting the "default" field, which was a currently wrong behavior in some UI logic.
github-project-automation
bot
moved this from In review 🔎
to To release 🤖
in Sprint Q1/2025
slint
added a commit
that referenced
this issue
Nov 19, 2024
* Closes #2869. * Passes "null" instead of empty string ("") as the "default" field value when removing community branding from a record.
slint
added a commit
to zenodo/zenodo-rdm
that referenced
this issue
Nov 19, 2024
📁 invenio-oauthclient (4.1.0 -> 4.1.1 🐛)
release: v4.1.1
handlers: add basic error handling for roles creation
fix: compat for flask-oauthlib
📁 invenio-rdm-records (16.1.0 -> 16.2.0 🌈)
📦 release: v16.2.0
search: pass search parameters
semantic-ui: CommunitySelectionModal: Remove unused Footer component
📦 release: v16.1.1
communities: fix set/unset of default record community
* Closes inveniosoftware/invenio-app-rdm#2869
* Fixes the allowed values that can be passed to set/unset the default
community of a record.
* Part of the fix is to also accept an empty string ("") as a valid
value when setting the "default" field, which was a currently wrong
behavior in some UI logic.
📁 invenio-rest (1.3.1 -> 1.4.0 🌈)
release: 1.4.0
setup: move to pytest-black-ng
* reorder alphabetical test_requires
fix: forward compatibility with flask>=3.0
* the set_cookie needs a string encoded cookie but str() is not enough,
because it contains a "b'" which creates problem down the road.
global: use jws from invenio-base
* jws functionality has been removed from itsdangerous >= 2.1.0. the
functionality has been moved to invenio-base
global: remove six usage
* string_types has been replaced by builtin str
* urlencode has been replaced by builtin urllib.parse.urlencode
slint
added a commit
to zenodo/zenodo-rdm
that referenced
this issue
Nov 28, 2024
📁 invenio-app-rdm (13.0.0b1.dev18 -> 13.0.0b1.dev20 🌈)
📦 release: v13.0.0b1.dev20
config: add subcommunity invitation request notifications
requests: add subcommunity invitation request details page
creatibutors: added config for identifiers scheme
release: v13.0.0b1.dev19
communities_ui: views: Add RecordPermissionDeniedError Handler
semantic-ui: users: header: Pass entrypoint namespace in url_for
fix: ui: escape journal title once
package: remove unused AUTHORS.rst (inveniosoftware/invenio-app-rdm#2735)
records-ui: fix removing community branding
* Closes inveniosoftware/invenio-app-rdm#2869.
* Passes "null" instead of empty string ("") as the "default" field
value when removing community branding from a record.
semantic-ui: users: header: Use endpoints from config
upgrades: remove record JSONSchema version bump
config: removed unecessary INDEXER_DEFAULT_INDEX
📁 invenio-celery (1.3.1 -> 1.3.2 🐛)
release: v1.3.2
setup: upper pin packages
* step to go forwards with flask >= 3.0
* to have clear boundaries on the invenio packages
docs: Typo in the example
📁 invenio-communities (17.4.0 -> 17.5.0 🌈)
📦 release: v17.5.0
service: add data to inivitation req
delete unused file and add expiry to email
service: add create_subcommunity_invitation_request
refactor and fix bugs in sending emails
subcommunities: add invitation actions
subcommunities: add invitation notifications
request: add subcommunity invitation request
config: add LogoNotFoundError
previously it was a generic error
communities: config: Update static page URLs to prevent name collisions
📁 invenio-files-rest (2.2.2 -> 2.2.3 🐛)
release: v2.2.3
setup: change to reusable workflows
setup: pin dependencies
📁 invenio-i18n (2.1.2 -> 2.2.0 🌈)
release: v2.2.0
setup: upper pin packages
fix: my-site not overriding packages
* the way how babel picks the translations the my-site has to be the
last option because it overrides the entries before
ext: add bundle entrypoint
github: update reusable workflows
📁 invenio-logging (2.1.1 -> 2.1.2 🐛)
release: v2.1.2
setup: change to reusable workflows
setup: pin dependencies
📁 invenio-rdm-records (16.2.0 -> 16.3.0 🌈)
📦 release: v16.3.0
github: added default license from Github API
deposit-ui: fix affiliations rendering during edits
release: added custom_fields
datacite: improve error logging formatting and grouping
* Avoids f-strings in logging calls so that entries are easier to be
grouped.
* Adds exception info to the logged errors.
config: added service schema from config
* Added the swhid field to the bibtex schema
requests: manage sending notifications
📁 invenio-records-resources (6.4.0 -> 6.5.0 🌈)
📦 release: v6.5.0
queryparser: add CompositeSuggestQueryParser
* Introduces a new query parser focused on better accuracy for
mappings that contain search-as-you-type or ngram-analyzed fields but
also secondary information fields that helps to
disambiquate/narrow-down results.
📁 invenio-requests (5.3.0 -> 5.4.0 🌈)
📦 release: v5.4.0
refactor: clean up duplicated imports
UI: add seperator on list of requests
ui: add subcommunity invitation facet and label
ux: set tab title to request title
requests: add missing facets and reorder
📁 invenio-vocabularies (6.6.0 -> 6.7.0 🌈)
📦 release: v6.7.0
contrib: improve search accuracy for names, funders, affiliations
names: add affiliation acronym in mappings and schema
* Dereferences the affiliation `acronym` when indexing names and serving
REST API results. This is useful for disambiguating authors in search.
affiliations: move RDF and SPARQL as extra dependencies
* Moves `rdflib` and `SPARQLWrapper` to extras.
affiliation: refactored edmo datastreams
subjects: refactoring, updated schema and test
subjects: added datastream for gemet vocab
awards/schema.py: read app config for alternate funding validation (inveniosoftware/invenio-vocabularies#429)
awards: fix description field and mappings
awards: add fields start/end date and description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Package version (if known): v12
Describe the bug
Removing branding from a record in a community breaks the search and the record landing page.
It seems like it has to do with the communities
defaultfield being removed.Steps to Reproduce
Expected behavior
This should not break. Should the remove branding button even be there if no branding is applied?
Screenshots (if applicable)
Additional context
The text was updated successfully, but these errors were encountered: