Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: add post logout view #2235

Closed
wants to merge 1 commit into from
Closed

config: add post logout view #2235

wants to merge 1 commit into from

Conversation

jrcastro2
Copy link
Contributor

ntarocco
ntarocco reviewed Jun 7, 2023
View reviewed changes
invenio_app_rdm/config.py
# ========================

SECURITY_EMAIL_SUBJECT_REGISTER = _("Welcome to Invenio App RDM!")
"""Email subject for account registration emails."""

SECURITY_POST_LOGOUT_VIEW = "/oauth/logout"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would avoid putting this here by default, given that maybe no oauth is configured (only local login). It probably does not hurt, but maybe better to add it to the doc here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with only local accounts I think this would break, to be tested?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no it should not, because if you have no remotes configured, it will not redirect (if I am not mistaken). However, I will remove it, and document it instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it wouldn't break, but I will document it instead 👍

@jrcastro2
Copy link
Contributor Author

Closed as requested and replaced by the docs: inveniosoftware/docs-invenio-rdm#560

@jrcastro2 jrcastro2 closed this Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpsherva kpsherva kpsherva left review comments

@ntarocco ntarocco ntarocco left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DEPENDS ON #invenio-app-rdm/2186] CERN e-groups integration
3 participants
@jrcastro2 @ntarocco @kpsherva