invitations: rework for the groups invitations #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anikachurilova
force-pushed
the
add-ui-tab-for-groups
branch
from
443a5ea to
9fcfdc6
Compare
anikachurilova
force-pushed
the
add-ui-tab-for-groups
branch
from
9fcfdc6 to
a6d81e2
Compare
kpsherva
reviewed
Apr 19, 2024
| </Form.Field> | ||
| <i> | ||
| {i18next.t( | ||
| "Note: upon addition, selected groups will become community members immediately without any kind of notification." |
There was a problem hiding this comment.
minor, to make sure invitation is also referenced:
Suggested change
| "Note: upon addition, selected groups will become community members immediately without any kind of notification." | |
| "Note: upon addition, selected groups will become community members immediately without any kind of notification or invitation approval." |
side thought: do we need a confirmation modal for this action?
There was a problem hiding this comment.
Thanks for noticing!
I'm not sure the confirmation modal is necessary here, as we are not doing something dangerous that can not be undone. After closing the modal, user can immediately remove groups access if they did something wrong. What do you think?
ntarocco
reviewed
Apr 19, 2024
anikachurilova
force-pushed
the
add-ui-tab-for-groups
branch
3 times, most recently
from
953d24b to
55d7e79
Compare
* deprecate COMMUNITIES_GROUPS_ENABLED (moved to USERS_RESOURCES_GROUPS_ENABLED) * closes inveniosoftware/invenio-app-rdm#2592
anikachurilova
force-pushed
the
add-ui-tab-for-groups
branch
from
55d7e79 to
55e7474
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Results counter:
Groups tab:
Changes in the community add members tab:
