Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve community prefix search #1178

Merged
merged 4 commits into from
Aug 26, 2024

Conversation

carlinmack
Copy link
Contributor

@carlinmack carlinmack commented Jul 24, 2024

❤️ Thank you for your contribution!

Close inveniosoftware/invenio-app-rdm#2759

Description

Please describe briefly your pull request.

  • add edge_ngram prefix search for community titles
  • add test case to verify (which fails without changes to mapping)

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

Copy link
Contributor

@jrcastro2 jrcastro2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@slint slint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlinmack carlinmack force-pushed the title-prefix-search branch from 18f83ef to d383a42 Compare August 26, 2024 12:14
@carlinmack
Copy link
Contributor Author

rebased on master

@jrcastro2 jrcastro2 merged commit 514c5ce into inveniosoftware:master Aug 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Searching for prefixes of words fails
5 participants