Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: add LogoNotFoundError #1251

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

carlinmack
Copy link
Contributor

@carlinmack carlinmack commented Nov 22, 2024

❤️ Thank you for your contribution!

Description

Please describe briefly your pull request.

Replacing generic error (FileNotFoundError was not imported from anywhere) with custom Invenio error

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

previously it was a generic error
@@ -22,7 +22,7 @@
from invenio_communities.proxies import current_communities

from ..communities.resources.ui_schema import TypesSchema
from ..members.records.api import Member
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removed line isn't on master so I'm confused

https://github.com/carlinmack/invenio-communities/blob/master/invenio_communities/views/communities.py

I removed it as Member isn't used

@slint slint merged commit afab78d into inveniosoftware:master Nov 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants