Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

files: abort with 500 on upload failures #536

Merged

Conversation

zzacharo
Copy link
Member

❤️ Thank you for your contribution!

Description

Please describe briefly your pull request.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@zzacharo zzacharo force-pushed the abort-on-file-upload-failures branch 5 times, most recently from 6af770d to 91225b3 Compare October 25, 2023 06:52
@@ -255,12 +257,17 @@ def set_file_content(

except FailedFileUploadException as e:
file = e.file
current_app.logger.exception(f"File upload failed: {str(e)}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
current_app.logger.exception(f"File upload failed: {str(e)}")
current_app.logger.exception("File upload transfer failed.")

For better Sentry grouping. We'll see the exception anyways there :)

@zzacharo zzacharo force-pushed the abort-on-file-upload-failures branch from 91225b3 to 6b7afe3 Compare October 25, 2023 07:41
@zzacharo zzacharo merged commit f0db406 into inveniosoftware:master Oct 25, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants