Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

processors: optionally use PyVIPS for image metadata #576

Merged
merged 1 commit into from
May 21, 2024
Merged

processors: optionally use PyVIPS for image metadata #576

merged 1 commit into from
May 21, 2024

Conversation

slint
Copy link
Member

@slint slint commented May 19, 2024 •
edited
Loading

  • If pyvips (and libvips on sysstem) are installed, PyVIPS is used to extract width and height for images.
  • Compared to Wand, PyVIPS has the benefit of not loading the entire image in memory to extract width/height metadata for the image (works for multi-layer images also, such as TIFFs and PDFs). See this gist for a small memory analysis.

@slint slint mentioned this pull request May 19, 2024
Merged
@slint slint requested a review from yashlamba May 21, 2024 06:29
yashlamba
yashlamba approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@yashlamba yashlamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@slint slint merged commit 39400d1 into inveniosoftware:master May 21, 2024
12 checks passed
@slint slint deleted the add-pyvips-support branch July 30, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashlamba yashlamba yashlamba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slint @yashlamba