entity resolvers: resolve drafts for notification purposes #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
anikachurilova
commented
May 23, 2024
anikachurilova
commented
- closes deposit form: share draft invenio-app-rdm#2667
anikachurilova
commented
May 23, 2024
| def matches_entity(self, entity): | ||
| """Check if the entity is a result item.""" | ||
| return isinstance(entity, (self.item_cls, self.record_cls)) | ||
| try: | ||
| return isinstance(entity, (self.item_cls, self.record_cls, self.draft_cls)) |
There was a problem hiding this comment.
Resolve draft to be able to send notifications for sharing access to drafts
kpsherva
reviewed
May 24, 2024
| return isinstance(entity, (self.item_cls, self.record_cls)) | ||
| try: | ||
| return isinstance(entity, (self.item_cls, self.record_cls, self.draft_cls)) | ||
| except AttributeError: |
There was a problem hiding this comment.
I am a bit worried that attribute level might be a bit too generic and hide other exceptions (not only the ones produced by accessing self.item_cls self.record_cls, self.draft_cls), but I don't have a good alternative for now
anikachurilova
force-pushed
the
notifications-for-drafts
branch
from
ae0251b to
6cd84a0
Compare
kpsherva
reviewed
May 24, 2024
| return is_item_or_record | ||
|
|
||
| try: | ||
| return isinstance(entity, self.draft_cls) |
There was a problem hiding this comment.
after a round of a chat, I understood that this part should be probably placed in entity resolver dedicated to drafts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.