files: sync metadata on file edit #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpsherva
reviewed
Jul 2, 2024
| @@ -360,7 +360,7 @@ def sync(self, src_files, delete_extras=True): | |||
| if obj_or_key in self: | |||
| del self[obj_or_key] | |||
| elif operation == "add": | |||
| self[obj_or_key.key] = obj_or_key | |||
| self[obj_or_key.key] = obj_or_key, dict(src_files[obj_or_key.key]) | |||
There was a problem hiding this comment.
just to understand what is happening: why do you need to cast it to dict? what type does src_files[obj_or_key.key] return ?
There was a problem hiding this comment.
I updated the code a bit more to be clear, essentially, I am trying to replicate exactly what's happening here:
src_files[obj_or_key.key] <- gives the latest file record and dict gives the "metadata"
alejandromumo
approved these changes
Jul 4, 2024
zzacharo
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We calculate image metadata when files are committed, which can happen on record edit as well.
Right now we only sync the file object version but not the metadata on edit - this PR fixes that.