-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mappings: add ngram analyzer #127
mappings: add ngram analyzer #127
Conversation
jrcastro2
commented
Feb 21, 2024
•
edited by carlinmack
Loading
edited by carlinmack
- Allows partial matches on search
- closes Some users cannot be found when inviting or setting restrictions CERNDocumentServer/cds-rdm#114
- closes Some users cannot be found when inviting or setting restrictions invenio-app-rdm#2752
invenio_users_resources/records/mappings/os-v1/users/user-v2.0.0.json
Outdated
Show resolved
Hide resolved
invenio_users_resources/records/mappings/os-v1/users/user-v2.0.0.json
Outdated
Show resolved
Hide resolved
invenio_users_resources/records/mappings/os-v2/users/user-v2.0.0.json
Outdated
Show resolved
Hide resolved
does this need rebasing? it seems like v2.0.0 was edited by Alex a few days after this PR https://github.com/inveniosoftware/invenio-users-resources/blob/master/invenio_users_resources/records/mappings/os-v1/users/user-v2.0.0.json |
* Allows partial matches on search * closes CERNDocumentServer/cds-rdm#114
b6792e7
to
20bbd8e
Compare
Cases which are failing:
|
The tests that were failing were searches which should produce no results. They were failing because the n-gram analyser was taking n-grams of the word (
We also had to change two of the test cases to be specific matches All the tests now pass as they do not match on the search queries |
609b9bd
to
bd0afa2
Compare
to be discussed https://opensearch.org/docs/latest/analyzers/#built-in-analyzers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
bd0afa2
to
a23a3e6
Compare
invenio_users_resources/records/mappings/os-v2/users/user-v3.0.0.json
Outdated
Show resolved
Hide resolved
invenio_users_resources/records/mappings/os-v1/users/user-v3.0.0.json
Outdated
Show resolved
Hide resolved
f396810
to
3a2c36c
Compare