-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mappings: add edge_ngram prefix search #372
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlinmack
commented
Jul 24, 2024
8685270
to
3d676dc
Compare
jrcastro2
reviewed
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a couple of questions to clarify it.
I noticed that for affiliation we apply the tokenizer to title, name and acronym while on funders we only apply it for the name, is this intended?
invenio_vocabularies/contrib/affiliations/mappings/os-v2/affiliations/affiliation-v2.0.0.json
Show resolved
Hide resolved
jrcastro2
reviewed
Jul 30, 2024
kpsherva
reviewed
Aug 1, 2024
kpsherva
reviewed
Aug 1, 2024
invenio_vocabularies/contrib/affiliations/mappings/os-v1/affiliations/affiliation-v2.0.0.json
Show resolved
Hide resolved
slint
reviewed
Aug 7, 2024
invenio_vocabularies/contrib/affiliations/mappings/os-v1/affiliations/affiliation-v2.0.0.json
Show resolved
Hide resolved
invenio_vocabularies/contrib/affiliations/mappings/os-v1/affiliations/affiliation-v2.0.0.json
Outdated
Show resolved
Hide resolved
slint
reviewed
Aug 13, 2024
invenio_vocabularies/contrib/funders/mappings/os-v1/funders/funder-v2.0.0.json
Outdated
Show resolved
Hide resolved
slint
reviewed
Aug 13, 2024
2e5748b
to
f2da03c
Compare
ba3e52f
to
7a49a63
Compare
slint
approved these changes
Aug 16, 2024
🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Close inveniosoftware/invenio-app-rdm#2759
Close inveniosoftware/invenio-app-rdm#2761
Description
for the three vocabularies (funders, affiliations and awards) I created a test for searching for the prefix, which failed. I then added the edge_ngram search to the mapping which made the test pass
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: