Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add December blog post #209

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

saragon02
Copy link
Contributor

@saragon02 saragon02 commented Dec 5, 2024

❤️ Thank you for your contribution!

Description

Please describe briefly your pull request.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

Copy link
Contributor

@mfenner mfenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text looks good to me. Minor suggestion: put in the date when the FreiData instance launched or was officially made available.

@JanLeendertse
Copy link

The text looks good to me. Minor suggestion: put in the date when the FreiData instance launched or was officially made available.

The release date was 27th of October, 2023.

We expected a slow progress of contributions for the first month. Currently I have several interested people who want to use the APIs.

I am looking into the source text, where to add that detail.

@JanLeendertse
Copy link

Hi Sara, hi Martin,

I do not have the access rights, and a change of the text requires a fork, which is a bit cumbersome for the slight change. So my suggestion to Martins request:

When InvenioRDM launched on 27th of October at the University of Freiburg under the label FreiData,

What do you think?

@mfenner
Copy link
Contributor

mfenner commented Dec 6, 2024 via email

@JanLeendertse
Copy link

JanLeendertse commented Dec 6, 2024

Jan, I like the suggested Text and can put it in the document for you.

I see that I forgot the year. It should be:

When InvenioRDM launched on 27th of October 2023 at the University of Freiburg under the label FreiData,

Sorry for the extra loop.

Copy link
Contributor

@mfenner mfenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I was at a workshop all day, so thanks Sara for adding the date).

Copy link
Contributor

@ntarocco ntarocco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (the website https://freidata.uni-freiburg.de/ is down at the time of writing this)

@saragon02 saragon02 merged commit dd87105 into inveniosoftware:master Dec 9, 2024
1 check passed
@JanLeendertse
Copy link

LGTM! (the website https://freidata.uni-freiburg.de/ is down at the time of writing this)

OMG. I will let check this. Thanks for hinting.

@JanLeendertse
Copy link

Is fixed.

@saragon02
Copy link
Contributor Author

Thanks Jan! The blog is live.

@JanLeendertse
Copy link

Thanks Jan! The blog is live.

Thanks for releasing, and for the opportunity to contribute. And for your patience.

@mfenner
Copy link
Contributor

mfenner commented Dec 9, 2024

Thanks Jan. One minor issue: the cropping of the feature image leads to a blue image. Is that ok, or should I crop the image differently (removing some of the sky on top)?

Bildschirmfoto 2024-12-09 um 21 23 30

@saragon02
Copy link
Contributor Author

Good point, Martin. The preview or thumbnail of the blog's first image is always a little funnily cropped like this. Perhaps there is a larger solution that could be applied to the website?

@mfenner
Copy link
Contributor

mfenner commented Dec 9, 2024

In my experience (in other blog platforms) the main issue with cropping is different proportions of images. Another issue is that the image is too big (5400 x 3600 px) making loading slow. I also see that several of the latest posts have same issue (lots of blue). Happy to tinker with the image but hope that @JanLeendertse doesn't mind.

@ntarocco
Copy link
Contributor

ntarocco commented Dec 9, 2024

Adding this to the style.css, it is a bit better (not perfect):

.blog-list-item-content img {
  width: 100%;
  height: 100%;
  object-fit: cover;
  object-position: center center;
}

Screenshot 2024-12-09 at 21 49 37

@mfenner
Copy link
Contributor

mfenner commented Dec 9, 2024

This looks much better. I also cropped the image to remove some of the blue sky at the top and use a more reasonable resolution (1200 x 620 px). Now trying to bring all this together.

ComputerCenter_UniversityFreiburg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants