remove, removeOne and splice methods & tests #7
Conversation
|
Would you mind sorting the linting issues if possible please, the ones listed under Happy to merge today after the changes - will do a release also. |
|
@Salakar Can you merge pr now? |
| } | ||
| if (this._head === this._tail) return void 0; | ||
| if (i > size || i < -size) return void 0; | ||
| if (i === size && count != 0) return void 0; |
There was a problem hiding this comment.
Not entirely sure what this line is trying to do? Could you clarify - your PR is missing quite a bit of coverage so i'm trying to bring it back up to 99%~
| if(count === 0){ | ||
| removed = []; | ||
| if(i != size){ | ||
| this._tail = (i - 1 + len) & this._capacityMask; |
There was a problem hiding this comment.
This line is also missing coverage
|
I've pushed up a few changes to your PR, if you could finish the rest from my review above that'd be great, thanks |
|
Thanks for review! Without line from here: #7 (review) |
No description provided.