Skip to content

Commit

Permalink
chore: refactor workflow and test files
Browse files Browse the repository at this point in the history
- Remove unnecessary TODO comment in the workflow file
- Update test command in workflow to remove unnecessary `|| true`
- Update dependency messages matcher in `matchers.dart` test file
  • Loading branch information
jessicatarra committed Jun 25, 2024
1 parent db9ab3c commit b3745c4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/validate.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,7 @@ jobs:
- name: Install Tools
run: ./.github/workflows/scripts/install-tools.sh
- name: Run Tests
# TODO: Remove | true once #724 iw solved.
run: melos test --no-select || true
run: melos test --no-select

test_windows:
runs-on: windows-latest
Expand Down
1 change: 1 addition & 0 deletions packages/melos/test/matchers.dart
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ Matcher ignoringDependencyMessages(String expected) {
.where(
(line) =>
!line.startsWith('Resolving dependencies...') &&
!line.startsWith('Downloading packages...') &&
!line.startsWith('Got dependencies!'),
)
.join('\n');
Expand Down

0 comments on commit b3745c4

Please sign in to comment.