fix: melos list --all --gviz --ignore foo, doesn't ignore foo

[lukepighetti]

Is there an existing issue for this?

• I have searched the existing issues.

Version

1.2.0

Description

melos list --all --graph --ignore analysis ignores package named 'analysis'
melos list --all --gviz --ignore analysis does not

% melos list --all --graph --ignore analysis
{
  "challenges": [],
  "gviz_url": [],
  "home_screen": [
    "widgets"
  ],
  "http_client": [],
  "mobile": [],
  "social_screen": [],
  "styles": [
    "widgets"
  ],
  "widgets": [
    "styles"
  ]
}

% melos list --all --gviz --ignore analysis
digraph packages {
  size="10"; ratio=fill;
  challenges [shape="box"; color="#b02dd5"];
  gviz_url [shape="box"; color="#fa9d3e"];
  home_screen [shape="box"; color="#dd9758"];
  http_client [shape="box"; color="#8e383c"];
  mobile [shape="box"; color="#b89bf4"];
  social_screen [shape="box"; color="#2c1b5d"];
  styles [shape="box"; color="#c9a27c"];
  widgets [shape="box"; color="#3ed5a4"];
  challenges -> analysis [style="dashed"; color="#7b54ca"];
  gviz_url -> analysis [style="dashed"; color="#7b54ca"];
  home_screen -> widgets [style="filled"; color="#3ed5a4"];
  home_screen -> analysis [style="dashed"; color="#7b54ca"];
  http_client -> analysis [style="dashed"; color="#7b54ca"];
  mobile -> analysis [style="dashed"; color="#7b54ca"];
  mobile -> home_screen [style="dashed"; color="#dd9758"];
  social_screen -> analysis [style="dashed"; color="#7b54ca"];
  styles -> widgets [style="filled"; color="#3ed5a4"];
  styles -> analysis [style="dashed"; color="#7b54ca"];
  widgets -> styles [style="filled"; color="#c9a27c"];
  widgets -> analysis [style="dashed"; color="#7b54ca"];
  subgraph "cluster features" {
    label="features";
    color="#a2d208";
    challenges;
    home_screen;
    social_screen;
  }
  subgraph "cluster tools" {
    label="tools";
    color="#29c70b";
    gviz_url;
  }
  subgraph "cluster libraries" {
    label="libraries";
    color="#263e6b";
    http_client;
    styles;
    widgets;
  }
  subgraph "cluster apps" {
    label="apps";
    color="#97a53f";
    mobile;
  }
}

Steps to reproduce

Lorem ipsum Steps to reproduce

Expected behavior

Lorem ipsum expected behavior

Screenshots

No response

Additional context and comments

No response

[blaugold]

Thanks for reporting this.

I think the bug is actually in the --graph option, not the --gviz one. Melos filters usually only act on the initial set of packages to process, but don't remove excluded packages from processing entirely. For melos list this means that only packages included by filters are listed, but a package's dependencies are all included.

--gviz includes normal and development dependencies, while --graph only includes normal dependencies, which seems inconsistent.