Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Flaky linux test #670

Closed
1 task done
spydon opened this issue Mar 21, 2024 · 6 comments · Fixed by #677
Closed
1 task done

fix: Flaky linux test #670

spydon opened this issue Mar 21, 2024 · 6 comments · Fixed by #677
Assignees
Labels
bug Something isn't working Type: Accepted

Comments

@spydon
Copy link
Collaborator

spydon commented Mar 21, 2024

Is there an existing issue for this?

  • I have searched the existing issues.

Version

5.2.1

Description

Some tests are flaky when they run for Linux in the the CI, example run:
https://github.com/invertase/melos/actions/runs/8373797082/job/22927655150

Steps to reproduce

Run the CI and ~50% of the time some linux tests will fail.

Expected behavior

Non-flaky tests.

Screenshots

No response

Additional context and comments

No response

@spydon spydon added bug Something isn't working Type: Accepted labels Mar 21, 2024
@spydon
Copy link
Collaborator Author

spydon commented Mar 21, 2024

Apparently also sometimes happens for windows:
https://github.com/invertase/melos/actions/runs/8374207232/job/22928929951?pr=671

@spydon
Copy link
Collaborator Author

spydon commented Mar 25, 2024

Here's another one: https://github.com/invertase/melos/actions/runs/8420212367/job/23054448154

@jessicatarra maybe you could have a look at this test if you have time: "multiple scripts verifies that a melos script can call another script containing steps, and ensures all commands in those steps are executed successfully"? :)
It seems to be the one that is the most flaky.

@jessicatarra
Copy link
Contributor

Sure, I'll take a look

@spydon
Copy link
Collaborator Author

spydon commented Mar 26, 2024

https://github.com/invertase/melos/actions/runs/8434508600/job/23098706712?pr=679 this seems to be the same problem as the one you solved right @jessicatarra, but on another test?

@jessicatarra
Copy link
Contributor

I'm uncertain if this is a flaky test, it seems like a real issue because it's failing across all environments, possibly a missing dependency. I'll take a look at this too

@jessicatarra
Copy link
Contributor

@spydon it's actually a flaky one so disregard my previous comment, it's actually a very similar issue as you mentioned, see the most recent log:

 test/workspace_test.dart: Workspace can be accessed from anywhere within a workspace (failed)
  Expected: 'a\n'
              ''
    Actual: 'Resolving dependencies...\n'
              'Got dependencies!\n'
              'a\n'
              ''
     Which: is different.
            Expected: a\n
              Actual: Resolving  ...
                      ^
             Differ at offset 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Type: Accepted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants