Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky tests linux CI/CD environments #2 #680

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

jessicatarra
Copy link
Contributor

@jessicatarra jessicatarra commented Mar 27, 2024

Description

The goal of this PR is to fix flaky tests in linux CI/CD environments mentioned in recently closed issue #670.

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

@jessicatarra jessicatarra changed the title test: fix bootstrap_test flaky test in linux CI/CD environments test: fix flaky tests in linux CI/CD environments #2 Mar 27, 2024
@jessicatarra
Copy link
Contributor Author

@Salakar @spydon Apparently this solves all flaky tests happening in Linux environments, but I would test it a few times before merging to make sure it actually works (flaky tests are very tricky ahah 😅)

@jessicatarra jessicatarra changed the title test: fix flaky tests in linux CI/CD environments #2 test: fix flaky tests linux CI/CD environments #2 Mar 27, 2024
Copy link
Collaborator

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-ran this a few times and it seems to work great, good job! 🥳

@spydon spydon merged commit 69b7fae into invertase:main Mar 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants