Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scripts.*.exec.failFast option in melos.yaml #359

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

alex-sandri
Copy link
Contributor

Description

--fail-fast is a flag and not an option and as such does not accept any value.

Example

This config is currently broken as in the generated command --fail-fast true is not valid syntax.

scripts:
  lint:
    run: flutter analyze
    exec:
      failFast: true
      concurrency: 1

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

@CLAassistant
Copy link

CLAassistant commented Aug 8, 2022

CLA assistant check
All committers have signed the CLA.

@blaugold blaugold changed the title fix: fail-fast is a flag and not an option (does not accept a value) fix: scripts.*.exec.failFast option in melos.yaml Aug 15, 2022
@blaugold
Copy link
Collaborator

Good catch! Thank you.

@blaugold blaugold merged commit 16fe691 into invertase:main Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants