Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failing tests due to Flutter upgrade to version 3.27. #812

Merged
merged 4 commits into from
Jan 3, 2025
Merged

fix: failing tests due to Flutter upgrade to version 3.27. #812

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
58a6445
fix: failing tests due to Flutter upgrade to version 3.27.
mahmuttaskiran Jan 3, 2025
290217b
fix: analysis issues
mahmuttaskiran Jan 3, 2025
aa69b44
ignore: dead_null_aware_expression until min sdk version is bumped
mahmuttaskiran Jan 3, 2025
646e300
Re-trigger check
spydon Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/melos/test/commands/bootstrap_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,9 +401,9 @@
updatedPubspecOverrides: '''
# melos_managed_dependency_overrides: a
dependency_overrides:
x: any
a:
path: ../a
x: any
''',
);
});
Expand Down Expand Up @@ -858,7 +858,7 @@
equals(defaultTestEnvironment),
);
expect(
pubspecA.environment?['sdk'],

Check warning on line 861 in packages/melos/test/commands/bootstrap_test.dart

View workflow job for this annotation

GitHub Actions / analyze

The receiver can't be null, so the null-aware operator '?[' is unnecessary. 

Try replacing the operator '?[' with '['.
See https://dart.dev/diagnostics/invalid_null_aware_operator to learn more about this problem.
equals(VersionConstraint.parse('>=2.18.0 <3.0.0')),
);
expect(
Expand All @@ -883,11 +883,11 @@
);

expect(
pubspecBPreBootstrap.environment?['flutter'],

Check warning on line 886 in packages/melos/test/commands/bootstrap_test.dart

View workflow job for this annotation

GitHub Actions / analyze

The receiver can't be null, so the null-aware operator '?[' is unnecessary. 

Try replacing the operator '?[' with '['.
See https://dart.dev/diagnostics/invalid_null_aware_operator to learn more about this problem.
equals(VersionConstraint.parse('>=2.12.0 <3.0.0')),
);
expect(
pubspecB.environment?['flutter'],

Check warning on line 890 in packages/melos/test/commands/bootstrap_test.dart

View workflow job for this annotation

GitHub Actions / analyze

The receiver can't be null, so the null-aware operator '?[' is unnecessary. 

Try replacing the operator '?[' with '['.
See https://dart.dev/diagnostics/invalid_null_aware_operator to learn more about this problem.
equals(VersionConstraint.parse('>=2.18.0 <3.0.0')),
);
expect(
Expand Down
2 changes: 2 additions & 0 deletions packages/melos/test/matchers.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ Matcher ignoringDependencyMessages(String expected) {
!line.startsWith('Got dependencies!') &&
// Removes lines like " pub_updater 0.4.0 (0.5.0 available)"
!(line.startsWith(' ') && line.contains(' available)')) &&
!line.startsWith('No dependencies would change in') &&
!line.startsWith('Would change') &&
!line.contains(
'newer versions incompatible with dependency constraints',
) &&
Expand Down
Loading