fix: Assertion issue with SDXL Compel #5827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blessedcoolant
requested review from
psychedelicious,
brandonrising and
hipsterusername
as code owners
github-actions
bot
added
python
blessedcoolant
requested review from
lstein,
GreggHelt2 and
RyanJDick
as code owners
psychedelicious
approved these changes
Feb 29, 2024
blessedcoolant
force-pushed
the
clip-assertion-fix
branch
from
493c0f1 to
29ba8a6
Compare
blessedcoolant
force-pushed
the
clip-assertion-fix
branch
from
29ba8a6 to
f9aaa73
Compare
brandonrising
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Fix assertion issue in
compel.py. Currently we check for just an instance ofCLIPTextModelbut SDXL text encoder can be eitherCLIPTextModelorCLIPTextModelWithProjection. This PR updates the assertion to permit either.