Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: workflow builder #7608

Draft
wants to merge 99 commits into
base: main
Choose a base branch
from
Draft

feat: workflow builder #7608

wants to merge 99 commits into from

Conversation

psychedelicious
Copy link
Collaborator

@psychedelicious psychedelicious commented Jan 31, 2025 •
edited
Loading

Summary

  • Add drag-and-drop workflow builder UI, replacing the simple list of linear view fields. Old linear view is migrated.
  • Refactor of a crapload of workflows components.
  • Fix issues with auto-node selection when creating edges.
  • Improved performance across workflow editor.
  • Upgrade reactflow to latest. I was already fixing/changing a ton of stuff so it was a good time to lump this in.
  • Update @invoke-ai/ui-library to latest. Needed for some of the UI stuff in workflow builder.
  • When loading a workflow, nodes are auto-updated.

Related Issues / Discussions

TBD

QA Instructions

TBD

Merge Plan

TBD

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added frontend-deps PRs that change frontend dependencies frontend PRs that change frontend files labels Jan 31, 2025
@psychedelicious psychedelicious mentioned this pull request Jan 31, 2025
Closed
1 task
@psychedelicious psychedelicious force-pushed the psyche/feat/workflow-builder branch from 41bcd84 to e633122 Compare February 5, 2025 06:34
@psychedelicious
feat(ui): add notes state to fields
756f1ea
@psychedelicious
feat(ui): add notes popover to field title bar
b48c5f1
@psychedelicious
feat(ui): show notes icon on editor linear view
574733a
@psychedelicious
feat(ui): show notes icon on user-linear view, replacing info icon
e88af1f
@psychedelicious
feat(ui): clean up user-linear view styling
c6eb93f
@psychedelicious
feat(ui): add ViewContext so components can know where they are being…
911034c 
… rendered (user-linear view, editor-linear view, or editor-nodes view)
@psychedelicious
perf(ui): use data attribute for input field wrapper styles
6663cdf
@psychedelicious
refactor(ui): workflows component structure (WIP)
ae815f1 
- Simplify and de-insane-ify component structure, hooks, selectors, etc.
- Some perf improvements by using data attributes for styling instead of dynamic CSS-in-JS.
- Add field notes and start of linear view config, got blocked when I ran into deeper layout issues that made it very difficult to handle field configs. So those are WIP in this commit.
@psychedelicious
refactor(ui): workflows left panel internal components structure
d979117
@psychedelicious
fix(ui): remove accidental change to zFieldInput schema
0680831
@psychedelicious
refactor(ui): continued reorg of components & hooks
56bd8ad
@psychedelicious
refactor(ui): continued reorg of components & hooks
fb38e3b
@psychedelicious
fix(ui): color field component layout
cb7dc18
@psychedelicious
feat(ui): get configurable notes display working
1cc0c98
@psychedelicious
feat(ui): use workflows view context
00edd30
@psychedelicious
fix(ui): dynamic prompts infinite recursion (wip)
487ca39
@psychedelicious
feat(ui): rough out workflow builder data structure & dummy data
66cda9d
@psychedelicious
refactor(ui): split up float and integer field renderers
f6d13f5
@psychedelicious
revert(ui): rip out linear view config stuff
2cca28e
@psychedelicious
refactor(ui): split integer, float and string field components in pre…
1e0f121 
…p for builder
@psychedelicious
feat(ui): rough out workflow builder data structure
99be361
@psychedelicious
chore(ui): lint
67b9d65
@psychedelicious
feat(ui): iterate on builder (WIP)
7ad1a3f
@psychedelicious
feat(ui): iterate on builder (WIP)
6f6c433
@psychedelicious
feat(ui): iterate on builder (WIP)
8339b56
@psychedelicious
feat(ui): empty state for drop containers
63831ac
@psychedelicious
feat(ui): builder empty state (WIP)
1040e92
@psychedelicious
feat(ui): string field settings
bff452e
@psychedelicious
feat(ui): delete form elements when node is deleted from workflow
531f0f7
@psychedelicious
feat(ui): iterate on builder data structure
604d08c
@psychedelicious
fix(ui): remove node field from form correctly when node is deleted
31bdd3a
@psychedelicious
feat(ui): make drop targets that are in root sticky
5d161d0
@psychedelicious
feat(ui): builder edit/view buttons
a238747
@psychedelicious
fix(ui): divider rendering
050cb62
@psychedelicious
refactor(ui): add dispatchAndFlash util for dnd
ec9f001
@psychedelicious
tidy(ui): rename root utils in dnd
0f74cad
@psychedelicious
refactor(ui): clean up dnd logic
9f4861b
@psychedelicious
refactor(ui): add vars in dnd logic for conciseness
6cf9924
@psychedelicious
tidy(ui): dnd logic formatting
3f27632
@psychedelicious
tidy(ui): improve dnd hook names
5c05671
@psychedelicious
tidy(ui): rename builder dnd file
b2e9e86
@psychedelicious
tidy(ui): dnd code lint
326f1bf
@psychedelicious
revert(ui): code lint that broke stuff
c89460a
@psychedelicious
feat(ui): workflow builder layout
e0b0ce5
@psychedelicious
feat(ui): be double extra sure migrated workflows are parsed before l…
23449f8 
…oading
@psychedelicious
fix(ui): do not error in node/field selectors are used outside field …
5174e02 
…gate components
@psychedelicious
feat(ui): migrated linear view exposed fields to builder form on load
4c87260
@psychedelicious psychedelicious force-pushed the psyche/feat/workflow-builder branch from 88c84a5 to 4c87260 Compare February 7, 2025 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant will be requested when the pull request is marked ready for review blessedcoolant is a code owner

@maryhipp maryhipp Awaiting requested review from maryhipp maryhipp will be requested when the pull request is marked ready for review maryhipp is a code owner

@hipsterusername hipsterusername Awaiting requested review from hipsterusername hipsterusername will be requested when the pull request is marked ready for review hipsterusername is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
DO NOT MERGE frontend PRs that change frontend files frontend-deps PRs that change frontend dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@psychedelicious