This repository has been archived by the owner on Nov 29, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7
Defined label_formatter parameter on Widgets #48
Merged
+39
−6
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
985e5f8
Defined label_formatter parameter on Widgets
jlstevens 881f393
Fixed typos
jbednar 8dc2816
Added support for None to disable label formatter
jlstevens a008e86
Added overrides parameter for arbitrary label mapping
jlstevens 2e10365
Fixed issue with using title as a key
jlstevens 8241d52
Removed outdated use of __call__ for holoviews objects
jlstevens 5619157
Attempt at fixing sphinx requirement of nbsite
jlstevens File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -94,10 +94,10 @@ def RangeWidget(*args, **kw): | |
return RangeSlider(*args, **kw) | ||
|
||
def PlotWidget(*args, **kw): | ||
return column(name=kw['title']) | ||
return column(name=kw['name']) | ||
|
||
def HTMLWidget(*args, **kw): | ||
return Div(name=kw['title']) | ||
return Div(name=kw['name']) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Definitely sure this is the only two cases where this change is needed? |
||
|
||
|
||
ptype2wtype = { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why we need this conditional anymore. @ceball ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not quite sure how this is in a pr about label format (I'm on my phone so can't easily see whole context), but isn't this just a case of parambokeh not having been updated to use autover yet?