Fix DeprecationWarning about 'U' open mode #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that we have a constant for PY3 in https://github.com/ionelmc/pytest-benchmark/blob/master/src/pytest_benchmark/compat.py#L3 - makes it easier to find all the python version checks though the code. |
According to https://docs.python.org/3.3/library/functions.html#open : "'U' universal newlines mode (for backwards compatibility; should not be used in new code)" To control how universal newlines works there is "newline" option. So, to fix it is enough to remove "U" from set of open options. Fixes: ionelmc#137 Signed-off-by: Stanislav Levin <[email protected]>
stanislavlevin
force-pushed
the
fix_u_depr_warning
branch
from
1e676c3 to
b204711
Compare
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
=========================================
Coverage ? 78.05%
=========================================
Files ? 16
Lines ? 1736
Branches ? 316
=========================================
Hits ? 1355
Misses ? 322
Partials ? 59
Continue to review full report at Codecov.
|
|
Thanks, fixed. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://docs.python.org/3.3/library/functions.html#open :
"'U' universal newlines mode (for backwards compatibility; should not
be used in new code)"
To control how universal newlines works there is "newline" option.
So, to fix it is enough to remove "U" from a set of open options.
Fixes: #137