add more info about the actual CPU we used

[antocuni]

this is a very important info, as we want to avoid comparing against different CPUs :)

[codecov-io]

Current coverage is 60.33% (diff: 90.00%)

Merging #61 into master will increase coverage by 0.18%

@@             master        #61   diff @@
==========================================
  Files            16         16          
  Lines          1611       1621    +10   
  Methods           0          0          
  Messages          0          0          
  Branches        294        295     +1   
==========================================
+ Hits            969        978     +9   
- Misses          589        590     +1   
  Partials         53         53          

Powered by Codecov. Last update 75e5eef...983650a

[ionelmc]

Interesting, are you using this extra stuff anywhere? (or plan to)

(not against these changes btw)

[ionelmc]

How about just extra or maybe even annotations? Or annotate(foo='bar')? Hmmmm

[antocuni]

I used extra_info for consistency with machine_info, commit_info, etc.
I don't like annotations, but I could live with that :)
About annotate(foo='bar'): if you intend to use it as a decorator, it would not work in my case because the value depends on the params (see the capnpy example below)

[ionelmc]

Now it makes sense :-)

[antocuni]

Yes, I am using the extra_info stuff for capnpy bencharks;

1. first, I use extra_info to remember what is the "attribute_type" for all the benchmarks of group "getattr":
   https://github.com/antocuni/capnpy/blob/master/capnpy/benchmarks/test_benchmarks.py
2. then, I use this info to group the data when I generate the charts:
   https://github.com/antocuni/capnpy/blob/master/travis/generate_charts.py#L154

In theory, I could recompute the attribute by parsing the textual name of the test, but it's horrible :). Plus, I think it could be generally useful to be able to attach extra infos to your benchmarks.

[ionelmc]

Would you mind adding some changelog entry + readme update? I think we can have this in the second alpha release.

[antocuni]

Done. I am also thinking about recording the git branch in commit_info, if you like the idea (if you don't, I can probably just use the hook and do it locally)

[ionelmc]

I've been thinking, maybe it's better to leave out this extra info. Not because it's not useful but then people would wonder why don't we also have the tag(s), commit message, author or other things that can be easily be extracted with the commit id.

[antocuni]

actually branch cannot be easily extracted afterwards, because it does not belong to the commit: if I merge and delete the branch, then the information is lost.
But as I said if you don't think it's an useful feature, I am fine with using the hook :).
Thanks!

[ionelmc]

Well you have a fair point there. Hmmm ...

[ionelmc]

@antocuni ok I changed my mind. Feel free to add it in another PR if you still wanna do it.