Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No .gitignore for electron #1560

Closed
2 of 7 tasks
stevenroussey-privicy opened this issue May 22, 2019 · 0 comments · Fixed by #1662
Closed
2 of 7 tasks

No .gitignore for electron #1560

stevenroussey-privicy opened this issue May 22, 2019 · 0 comments · Fixed by #1662

Comments

@stevenroussey-privicy
Copy link

Description of the problem:
No .gitignore in electron folder, so the node_modules and app folder get added unexpectedly.

ios and android have them, so no such problem there.

Affected platform

  • Android
  • iOS
  • electron
  • web

OS of the development machine

  • Windows
  • macOS
  • linux

Other information:

Capacitor version: 1.0.0-beta25

node version:

npm version:

CocoaPods version:

Steps to reproduce:

Link to sample project:

devinshoemaker added a commit to devinshoemaker/capacitor that referenced this issue Jun 13, 2019
The `app/` directory is generated with `npx cap copy electron` and consequently can be ignored. Also, `node_modules/` can be ignored for obvious reasons.

This also resolves ionic-team#1560.
jcesarmobile pushed a commit that referenced this issue Jun 14, 2019
The `app/` directory is generated with `npx cap copy electron` and consequently can be ignored. Also, `node_modules/` can be ignored for obvious reasons.

This also resolves #1560.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant