Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): Ensure appStateChange doesn't fire on startup #2179

Merged
merged 1 commit into from
Dec 9, 2019
Merged

fix(android): Ensure appStateChange doesn't fire on startup #2179

merged 1 commit into from
Dec 9, 2019

Conversation

Justin-Credible
Copy link
Contributor

Resolves #2178

@jcesarmobile jcesarmobile changed the title Ensure Android's appStateChange behaves like iOS fix(android): Ensure appStateChange doesn't fire on startup Dec 9, 2019
jcesarmobile
jcesarmobile approved these changes Dec 9, 2019
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense, thanks!

@jcesarmobile jcesarmobile merged commit 77a04c5 into ionic-team:master Dec 9, 2019
@Justin-Credible Justin-Credible deleted the fix/android-fires-app-resume-twice branch December 10, 2019 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Inconsistency with appStateChange between iOS and Android
2 participants
@Justin-Credible @jcesarmobile