New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): make Browser plugin fire browserFinished #2332

Merged

jcesarmobile merged 1 commit into ionic-team:master from jcesarmobile:fire-finished

Jan 23, 2020

Member

jcesarmobile commented Jan 14, 2020 •

edited

Loading

Closes #2239
Closes #2202


          fix(android): make Browser plugin fire browserFinished

94c60a3

jcesarmobile mentioned this pull request

Fix browserFinished not fired on Android #2239

Closed

jcesarmobile merged commit 4f5a4fc into ionic-team:master

jcesarmobile deleted the fire-finished branch

January 23, 2020 13:01

fohlin mentioned this pull request

bug: Browser plugin does not trigger browserFinished event correctly for Android #3896

Closed

Torone commented Aug 24, 2021

This fix didn't solve the issue.
The addListener for browserFinished is never fired when the Browser get closed.

        await Plugins.Browser.open({ url })
        Plugins.Browser.addListener('browserFinished', async () => {
          console.log('Never get here...')
          await this.$auth.fetchUser()
        })

ionic-team locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet