Skip to content

Commit

Permalink
fix(react): accept environment variables into build process
Browse files Browse the repository at this point in the history
fixes #4333
  • Loading branch information
imhoffd committed Mar 9, 2020
1 parent a5de3a7 commit 0932ff0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/@ionic/cli/src/lib/project/react/build.ts
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,6 @@ export class ReactBuildCLI extends BuildCLI<ReactBuildOptions> {
env.INLINE_RUNTIME_CHUNK = 'false';
}

return { ...super.buildEnvVars(options), ...env };
return { ...await super.buildEnvVars(options), ...env };
}
}
2 changes: 1 addition & 1 deletion packages/@ionic/cli/src/lib/project/react/serve.ts
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,6 @@ export class ReactServeCLI extends ServeCLI<ReactServeOptions> {
env.REACT_EDITOR = options.reactEditor;
}

return { ...super.buildEnvVars(options), ...env };
return { ...await super.buildEnvVars(options), ...env };
}
}

0 comments on commit 0932ff0

Please sign in to comment.