Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stacked labels for form controls #27229

Closed
3 tasks done
anddorua opened this issue Apr 18, 2023 · 5 comments
Closed
3 tasks done

feat: stacked labels for form controls #27229

anddorua opened this issue Apr 18, 2023 · 5 comments
Labels
package: core @ionic/core package type: feature request a new feature, enhancement, or improvement

Comments

@anddorua
Copy link

Prerequisites

Describe the Feature Request

Controls should be able to work with external labels. I.e. for any control sibling <label for="control-id">Text</label> might be attached and pressing on this label should apply focus on the control.

Describe the Use Case

Right now in v.7.0.1 I can't attach labels to the ion-checkbox elements to implement the following layout:
image

with this code:

<div class="week-container" formGroupName="weekDays">
  <label
    *ngFor="let day of weekDays; let i = index"
    for="day{{ i }}"
    class="label"
    >{{ day }}</label
  >
  <ion-checkbox
    *ngFor="let control of dayArray.controls; let i = index"
    formControlName="{{ i }}"
    id="day{{ i }}"
  ></ion-checkbox>
</div>

Describe Preferred Solution

No response

Describe Alternatives

No response

Related Code

No response

Additional Information

No response

@RRGT19
Copy link

RRGT19 commented Aug 10, 2023

@liamdebeasi
Any update on this feat? It would be really helpful. In fact, I'm waiting for this to finish our migration from v6 to v7.

@thetaPC
Copy link
Contributor

thetaPC commented Sep 6, 2023

Thanks for the issue! This has been implemented via PR #28075 and will be available in an upcoming minor release of Ionic.

@thetaPC thetaPC closed this as completed Sep 6, 2023
@RRGT19
Copy link

RRGT19 commented Sep 13, 2023

Hi team, @thetaPC @liamdebeasi

Saw a new minor release (7.3.4) without this fix. A friendly reminder of this.

@liamdebeasi
Copy link
Contributor

liamdebeasi commented Sep 13, 2023

This is a feature, so it will be in a minor release of Ionic not a patch release as noted in #27229 (comment).

edit: Ionic 7.3.4 is a patch release since we changed the last digit (7.3.3 --> 7.3.4)

@ionitron-bot
Copy link

ionitron-bot bot commented Oct 13, 2023

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: feature request a new feature, enhancement, or improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants