-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segment: add transition to hover #5308
Comments
Should just be able to change the opacity to fix this right? If so i can knock this out real quick. |
The opacity on hover needs to be lightened to https://github.com/driftyco/ionic/blob/2.0/ionic/components/segment/segment.ios.scss |
Ill handle this one. (: |
@jgw96 Cool, thanks! Let me know if you have any questions! |
@brandyscarney no probs! |
@brandyscarney quick question, the activated class seems to be applied to the segment when the segment is selected, aka clicked, so shouldn't it be at 1.0 opacity then? So you would have hover with 0.1 opacity and then when the selected class is applied it goes to 1.0 opacity. With your pic/explanation above it seems that we want to make the opacity 0.16 when the activated class is applied, but that means when that segment is chosen it goes to 0.16 opacity, which is pretty ugly. |
No, your perfectly fine, that makes much more sense now. Thanks for the response! |
Pull request submitted above! Thanks for the help @brandyscarney If i need to change anything just tell me and ill change it. |
…ts and remove activated css closes #5308
@jgw96 Thank you for the PR! I haven't checked on this in awhile, but I see Adam merged it! I added a fix for the colorized segments, too. Thanks again. 😄 |
Hover needs to be lighter but tap can stay the same as it is now
The text was updated successfully, but these errors were encountered: