Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite Scroll #5415

Closed
adamdbradley opened this issue Feb 11, 2016 · 15 comments
Closed

Infinite Scroll #5415

adamdbradley opened this issue Feb 11, 2016 · 15 comments
Assignees
Milestone

Comments

@adamdbradley
Copy link
Contributor

No description provided.

@adamdbradley adamdbradley self-assigned this Feb 11, 2016
@adamdbradley adamdbradley added this to the 2.0.0-beta.2 milestone Feb 11, 2016
@jboothe
Copy link

jboothe commented Feb 23, 2016

Adam, how's the progress on this? I'm upgrading a public app from Ionic 1 to 2 and don't want to eliminate the feature. Thanks for all the fantastic work!

@ryanlin1986
Copy link

We are waiting for this feature as well, since it's essential feature we can not live without it

@sclausen
Copy link
Contributor

+1

1 similar comment
@abierbaum
Copy link

👍

@MrBokeh
Copy link

MrBokeh commented Feb 26, 2016

@sphaso
Copy link

sphaso commented Feb 26, 2016

+1

adamdbradley added a commit that referenced this issue Feb 29, 2016
@adamdbradley
Copy link
Contributor Author

It's in the 2.0 branch and will go out in the beta2 release :)

@jboothe
Copy link

jboothe commented Feb 29, 2016

Great news! Thanks, Adam. I'll grab latest. Is beta2 due to go out soon?

brandyscarney added a commit that referenced this issue Feb 29, 2016
…roll

update API docs & rename endLoading function to complete.

references #5415
@brandyscarney
Copy link
Member

I've renamed ion-infinite to ion-infinite-scroll and ion-infinite-content to ion-infinite-scroll-content. Also endLoading() has been renamed to complete(). Please update these if you are using the 2.0 branch. We will release beta.2 when all issues in the milestone are complete and the framework has been thoroughly tested. 😄 You can always check out our milestones to see which issues are still open: https://github.com/driftyco/ionic/milestones/2.0.0-beta.2

@sclausen
Copy link
Contributor

sclausen commented Mar 1, 2016

@brandyscarney very nice! Is there somewhere a guide, how to use the 2.0 branch in my project?

@brandyscarney
Copy link
Member

@sclausen These steps should work, but let me know if they don't: https://github.com/driftyco/ionic/blob/2.0/scripts/README.md#developing-against-ionic-locally

😄

@sclausen
Copy link
Contributor

sclausen commented Mar 1, 2016

@brandyscarney many thanks!
Unfortunately, building won't work after linking.
I got a massive error output.
Here is the gist for stderr

And at the end in stdout

Your system information:

Cordova CLI: 6.0.0
Gulp version:  CLI version 3.9.1
Gulp local:   Local version 3.9.1
Ionic Version: 2.0.0-beta.1
Ionic CLI Version: 2.0.0-beta.17
Ionic App Lib Version: 2.0.0-beta.8
OS: Distributor ID: Ubuntu Description: Ubuntu 15.10 
Node Version: v5.7.0

@brandyscarney
Copy link
Member

@sclausen Quite a bit has changed in the framework. If you pull down the conference app: https://github.com/driftyco/ionic-conference-app

It should work to run ionic serve. We'll be releasing beta.2 and updating the changelog with some steps to upgrade.

@jboothe
Copy link

jboothe commented Mar 1, 2016

Get the following error when running ionic serve. I have latest ionic-conference-app and [email protected] is installed globally.

ERROR: Could not find your ionic.project file! Please run this command in the root of your ionic project.

However, if I start a new tutorial project:
ionic start MyIonic2Project tutorial --v2 --ts,
then app runs fine with
ionic serve.

What am I missing?


** Update **

  • downloaded a fresh ionic-conference-app
  • did not make any package name changes
  • npm install
  • ionic serve

Works. (btw, still using [email protected])

@sclausen
Copy link
Contributor

sclausen commented Mar 2, 2016

@brandyscarney you meant this?

import {Page} from 'ionic-angular';

beside this, your guide works like a charm, many thanks!!!

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants