Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popover #5420

Closed
5 tasks done
adamdbradley opened this issue Feb 11, 2016 · 1 comment
Closed
5 tasks done

Popover #5420

adamdbradley opened this issue Feb 11, 2016 · 1 comment
Assignees
@brandyscarney
Milestone
2.0.0-beta.8

Comments

@adamdbradley
Copy link
Contributor

adamdbradley commented Feb 11, 2016 •
edited by brandyscarney
Loading

  • Component
  • e2e tests
  • API docs
  • API demo
  • Add config properties to API
@adamdbradley adamdbradley self-assigned this Feb 11, 2016
@adamdbradley adamdbradley added this to the 2.0.0-beta.6 milestone Feb 11, 2016
@lbickston
Copy link

Ionic v1 popover had a ~300ms click blocker after the popover was removed to prevent clicks from propagating down. This hurt the user experience for users who were trying trying to quickly press buttons after the popover was removed.

Would be great if there was another solution in v2 instead of the click blocker.

@jgw96 jgw96 mentioned this issue Apr 5, 2016
Closed
@jgw96 jgw96 mentioned this issue May 9, 2016
Closed
brandyscarney added a commit that referenced this issue May 23, 2016
@brandyscarney
feat(popover): add popover component
53fd3c3 
references #5420
brandyscarney added a commit that referenced this issue May 23, 2016
@brandyscarney
feat(popover): change template in popover to a page similar to modal
a96e36a 
add ability to pass event in the transition, so on present of the
popover, clean up the positioning

references #5420
brandyscarney added a commit that referenced this issue May 23, 2016
@brandyscarney
feat(popover): position the popover on transition instead of create
2cd1b51 
references #5420
brandyscarney added a commit that referenced this issue May 24, 2016
@brandyscarney
style(popover): fix linter errors for sass and ts
1373108 
references #5420
brandyscarney added a commit that referenced this issue May 24, 2016
@brandyscarney
feat(popover): change popover item background color to match wrapper
b0d71da 
updated e2e test and added a test to open the popover

references #5420
brandyscarney added a commit that referenced this issue May 24, 2016
@brandyscarney
docs(demos): add popover API demo, tweak e2e demo
04a59d2 
references #5420
brandyscarney added a commit that referenced this issue May 25, 2016
@brandyscarney
docs(popover): update config docs to include popover transitions
ff1680c 
fix demos so the dot ripple displays correctly

references #5420
brandyscarney added a commit that referenced this issue May 25, 2016
@brandyscarney
feat(popover): modify the animation for each mode
57a1274 
add another wrapper div to fix the arrow not animating at the same time.

references #5420
brandyscarney added a commit that referenced this issue May 25, 2016
@brandyscarney
feat(popover): fix long popovers that go off the page
4db72cf 
Allow popovers to be of dynamic height and only cut them off when they
exceed the height of the body. Clean up styles for each mode.

references #5420
brandyscarney added a commit that referenced this issue May 25, 2016
@brandyscarney
feat(popover): add height auto for safari and remove ability to scrol…
620b7c8 
…l on backdrop

references #5420
brandyscarney added a commit that referenced this issue May 25, 2016
@brandyscarney
feat(popover): position popover in the top middle if no event
438a389 
add API docs for popover.

references #5420
@brandyscarney brandyscarney mentioned this issue May 25, 2016
Closed
3 tasks
brandyscarney added a commit that referenced this issue May 26, 2016
@brandyscarney
feat(popover): adjust popover to position in the center with no event
1e7b572 
references #5420
brandyscarney added a commit that referenced this issue May 26, 2016
@brandyscarney
feat(popover): add MD animation
1d0d755 
references #5420
brandyscarney added a commit that referenced this issue May 27, 2016
@brandyscarney
feat(popover): fix MD animations and start from the right side
e419ec6 
references #5420
brandyscarney added a commit that referenced this issue May 27, 2016
@brandyscarney
feat(popover): change MD animation and use for WP also
44a7da8 
references #5420
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brandyscarney brandyscarney

Labels
None yet
Projects
None yet
Milestone
2.0.0-beta.8
Development

No branches or pull requests
3 participants
@adamdbradley @brandyscarney @lbickston