Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review all Sass files for variables #5651

Closed
brandyscarney opened this issue Feb 29, 2016 · 1 comment
Closed

Review all Sass files for variables #5651

brandyscarney opened this issue Feb 29, 2016 · 1 comment
Assignees
@brandyscarney

Comments

@brandyscarney
Copy link
Member

brandyscarney commented Feb 29, 2016 •
edited
Loading

I need to go through all of the Sass files and make sure variables exist with the default flag for each one to make it easier to customize.
@brandyscarney brandyscarney self-assigned this Feb 29, 2016
brandyscarney added a commit that referenced this issue Feb 29, 2016
@brandyscarney
refactor(label): move label css to the correct scss files
4c93eb0 
references #5651
@brandyscarney brandyscarney added this to the 2.0.0-beta.3 milestone Feb 29, 2016
brandyscarney added a commit that referenced this issue Mar 3, 2016
@brandyscarney
refactor(sass): add Sass variables for action sheet and rename some
50b7d70 
also remove unused properties

references #5651
brandyscarney added a commit that referenced this issue Mar 3, 2016
@brandyscarney
refactor(sass): add Sass variables for alert, remove unused selectors
374efde 
renames some sass variables to work towards a standard convention

references #5651
brandyscarney added a commit that referenced this issue Mar 3, 2016
@brandyscarney
refactor(sass): replace all instances of bg in sass variables with ba…
8db6a85 
…ckground

references #5651
brandyscarney added a commit that referenced this issue Mar 3, 2016
@brandyscarney
refactor(sass): update windows action sheet sass to use variables
a51268c 
remove unused styles

references #5651
brandyscarney added a commit that referenced this issue Mar 3, 2016
@brandyscarney
refactor(sass): update windows alert sass to use variables
1e73a34 
renamed some properties, deleted unused ones

references #5651
brandyscarney added a commit that referenced this issue Mar 10, 2016
@brandyscarney
chore(sass): add custom sass linter config
bf3f016 
references #5651
brandyscarney added a commit that referenced this issue Mar 10, 2016
@brandyscarney
refactor(sass): rename bg to background in all sass variables
fe256c7 
BREAKING CHANGE:

`$item-ios-divider-bg` is now `$item-ios-divider-background`
`$item-ios-sliding-content-bg` is now
`$item-ios-sliding-content-background`

`$item-md-divider-bg` is now `$item-md-divider-background`
`$item-md-sliding-content-bg` is now
`$item-md-sliding-content-background`

`$item-wp-divider-bg` is now `$item-wp-divider-background`
`$item-wp-sliding-content-bg` is now
`$item-wp-sliding-content-background`

references #5651
@brandyscarney brandyscarney removed this from the 2.0.0-beta.5 milestone Apr 18, 2016
@brandyscarney brandyscarney mentioned this issue May 20, 2016
Closed
brandyscarney added a commit that referenced this issue Jul 29, 2016
@brandyscarney
refactor(tabs): update Sass variable naming to be more consistent
af01841 
Added comments on each Sass variable.

references #5651 references #7455
@brandyscarney brandyscarney mentioned this issue Aug 3, 2016
Closed
brandyscarney added a commit that referenced this issue Aug 9, 2016
@brandyscarney
refactor(button): update sass variable naming for all modes
5a3395d 
references #5651
references #7466
references ionic-team/ionic-site#613
@brandyscarney brandyscarney mentioned this issue Oct 18, 2016
Closed
30 tasks
@ionitron-bot
Copy link

ionitron-bot bot commented Sep 5, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brandyscarney brandyscarney

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adamdbradley @brandyscarney