Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tabs-top bug #943

Closed
zelphir opened this issue Mar 28, 2014 · 7 comments
Closed

tabs-top bug #943

zelphir opened this issue Mar 28, 2014 · 7 comments
Milestone
1.0.0-beta.2

Comments

@zelphir
Copy link

zelphir commented Mar 28, 2014

ionic 1.0.0-beat.1

Found a small bug with tabs-top. There are 2 different behaviours.

IOS

  • the tabs are underneath the header
  • the tab content is underneath the tabs list

screen shot 2014-03-28 at 10 24 56

Android

  • no problem with the header
  • same problem with the tab content

screenshot_2014-03-28-10-28-14

I had the problems in the project I'm working on (second screenshot), so I decided to start a clean project and just apply the tabs-top instead of tabs default. I've added also the side menu. No problems in the browser.
@ajoslin
Copy link
Contributor

ajoslin commented Mar 28, 2014

Hi @zelphir,

Could you post your HTML markup?

@ajoslin ajoslin added this to the 1.0.0-beta.2 milestone Mar 28, 2014
@ajoslin ajoslin self-assigned this Mar 28, 2014
@zelphir
Copy link
Author

zelphir commented Mar 28, 2014

It's ionic seed app!

I just changed here - tabs.html - line 7 from <ion-tabs class="tabs-icon-top tabs-default"> to <ion-tabs class="tabs-icon-top tabs-top">

@ajoslin
Copy link
Contributor

ajoslin commented Mar 28, 2014

OK, I see. It works in the browser: http://d.pr/i/yGR3

But when the status bar is active, the alignment is wrong.

@adamdbradley - the way we currently offset the header / subheader / etc for the status bar is by manually changing top values in the css. This seems really hard to upkeep.

Is it possible we could just offset the body for the status bar and just have the header/footer/etc elements just stay positioned relative to the body? Then we won't have to manually write new top values for everything.

ajoslin added a commit that referenced this issue Mar 31, 2014
@ajoslin
fix(scss): make tabs,header,footer aligned right with statusbar
c2a38a6 
Addresses #943

Before: we offset the has-header and other classes by 20px if a status
bar existed.

After: we simply offset the body by 20px if a status bar exists. This
makes the other classes automatically offset themselves.
@ajoslin
Copy link
Contributor

ajoslin commented Mar 31, 2014

Hi @zelphir! Could you give it a try with the latest nightly build and let me know?

@zelphir
Copy link
Author

zelphir commented Mar 31, 2014

Hi @ajoslin! Problem fixed... Well done!

Thanks

@ajoslin
Copy link
Contributor

ajoslin commented Mar 31, 2014

Awesome!

@ajoslin ajoslin closed this as completed Mar 31, 2014
@mkuffo
Copy link

mkuffo commented Jan 15, 2016

Thanks @zelphir! class="tabs-icon-top tabs-top" works for me Too.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0-beta.2
Development

No branches or pull requests
3 participants
@ajoslin @zelphir @mkuffo