Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(virtualScroll) remove items if array is null #12134

Closed
wants to merge 1 commit into from
Closed

fix(virtualScroll) remove items if array is null #12134

wants to merge 1 commit into from

Conversation

pablomaurer
Copy link

@pablomaurer pablomaurer commented Jun 22, 2017

Short description of what this resolves:

If you update the array with arr.length = 0 the items get removed. But when doing it like arr = [] the items will not disappear.

Changes proposed in this pull request:

  • When getting _recordSize check if we actually have an array else set to 0
  • Run through changes even when there are no records, so the previous items will get removed.
  • Be consistent and use everywhere the _recordSize instead _records.length

Ionic Version: 3.x

Fixes: #12034

@pablomaurer pablomaurer changed the title fix(virtualScroll) remote items if array is null fix(virtualScroll) remove items if array is null Jun 22, 2017
@pablomaurer
Copy link
Author

closed in favor of #12194

@pablomaurer pablomaurer mentioned this pull request Jun 28, 2017
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant