fix(virtualScroll) remove items if array is null #12134
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
If you update the array with
arr.length = 0
the items get removed. But when doing it likearr = []
the items will not disappear.Changes proposed in this pull request:
_recordSize
check if we actually have an array else set to 0changes
even when there are no records, so the previous items will get removed._recordSize
instead_records.length
Ionic Version: 3.x
Fixes: #12034